Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify MSI build process #1432

Closed
CharliePoole opened this issue Jul 1, 2024 · 5 comments
Closed

Simplify MSI build process #1432

CharliePoole opened this issue Jul 1, 2024 · 5 comments
Assignees

Comments

@CharliePoole
Copy link
Collaborator

I've had to make an number of changes to the platforms we support lately, most recently for issue #1430.

The msi package provides the greatest challenge in getting it right the first (or third or fourth) time. In part that's in the nature of the XML format we have to use, which is very complex. But a large part of the problem seems to stem from the two-step process we use, which is...

  1. Create an image directory containing what we want in the package.
  2. Create the msi package out of that directory

IIRC, I created that process many years ago because it seemed "simpler" to me. The problem is that when any thing fails to work, you have to start by figuring out which of the two steps created the problem - and sometimes it's both!

With this issue, I'd like to experiment with making it a one-step process. It seems that know where each file in the image came from, so, in principle, it should be possible to just grab that each file from that location directly in the .wxi entries.

In any case, I'll give it a go.

@CharliePoole CharliePoole added this to the 3.18.0 milestone Jul 1, 2024
@CharliePoole CharliePoole self-assigned this Jul 1, 2024
@CharliePoole
Copy link
Collaborator Author

@OsirisTerje If you have any thoughts of dropping the msi, however, let me know and I won't bother with this.

@OsirisTerje
Copy link
Member

Imho, I would drop the msi.
I believe we have enough ways of installing this.

@CharliePoole
Copy link
Collaborator Author

IIRC, I dropped it in V4. What about V3?

@OsirisTerje
Copy link
Member

Just drop it.

@CharliePoole
Copy link
Collaborator Author

Will do... closing this one...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants