Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update most tests to use the latest version of the nunit framework #1478

Closed
CharliePoole opened this issue Sep 14, 2024 · 2 comments · Fixed by #1485
Closed

Update most tests to use the latest version of the nunit framework #1478

CharliePoole opened this issue Sep 14, 2024 · 2 comments · Fixed by #1485
Assignees
Labels
Milestone

Comments

@CharliePoole
Copy link
Collaborator

CharliePoole commented Sep 14, 2024

Most of our test and testdata projects use version 3.13.3 of the NUnit engine. A few projects used only for package testing use version 4.1.

Ideally, all the tests of our own code should use the latest version of the framework. Most projects used as test data should do the same although we should retain enough that use older versions so that we are verifying continued backward compatibility.

I'll also update NSubstitute as needed to work with each version of NUnit.

This issue will probably be resolved using multiple PRs.

@CharliePoole CharliePoole added this to the 3.18.2 milestone Sep 14, 2024
@CharliePoole CharliePoole self-assigned this Sep 14, 2024
@CharliePoole
Copy link
Collaborator Author

After some experimentation, I have a plan for mixing versions of NUnit in our tests by tying the version to the runtime target, as follows:

  1. Tests targeting .NET Framework 4.6.2 or higher or .NET 6.0 or higher will use NUnit 4.1 initially (because some tests already use it) and will be upgraded to NUnit 4.2.2 in the next step.
  2. Tests targeting older runtimes will use NUnit 3.14
  3. As an exception, tests using the V2 Framework driver will use NUnit 2.6.4

As an initial step, in order to simplify the upgrade process, I'll move those test assemblies we use for test targets (e.g. mock-assembly) to a separate output directory.

@CharliePoole
Copy link
Collaborator Author

This issue has been resolved in version 3.18.2

The release is available on:
GitHub.
NuGet packages are also available NuGet.org and
Chocolatey Packages may be found at Chocolatey.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant