-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove RecentFilesService from Engine #874
Comments
@ChrisMaddock @jnm2 @rprouse @mikkelbu @OsirisTerje This is ready to go to a PR although I'm holding off for now until #896 is merged. That means we're at a decision point, so I've tried to mention everyone who may be impacted. If we treat this as a breaking change requiring a 4.0 release, merging it to master basically implies that there will be no more 3.x releases of the engine. That has been the plan, of course, but now it's time to be sure we are ready to commit to that. Options...
If we are going the route of (2), then I'll advance the version in the build script to 4.0 in addition to what I've done so far. |
In the framework, I made a Should we do the same here and prepare for 4.0? |
This should be in 4.0 in my opinion. My plan was to create a 4.0 branch and leave 3.13 as the master, merging 4.0 changes into the 4.0 branch, and eventually into master. So essentially the same as Rob's, but with a different default. We already have a bunch of non-breaking changes merged into master for 3.13 - I think it might be wise to keep the breaking ones separate for the time being, as we're not really clear on how long 4.0 will take. How do we feel about a separate 4.0 branch, and merging master into it now and again? Probably makes sense to merge in the 'big' PRs like the copyright header change before we create this branch. Charlie - if everyone agrees, would you mind setting this up with your PR? As it looks this this will be the first 4.0-specific PR! |
Marked as blocked by #896 |
Merged into the 4.0 branch |
This was merged to dev-4.0 and closed. I'm reopening it so as to replicate it in main. |
In TestCentric/testcentric-gui#582 we agreed that both projects would remove RecentFiles from the engine as it has nothing special to do with running tests. This is a breaking change.
The text was updated successfully, but these errors were encountered: