Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nunit.engine.tests are failing to unload on master branch #949

Closed
ChrisMaddock opened this issue May 9, 2021 · 2 comments · Fixed by #952
Closed

nunit.engine.tests are failing to unload on master branch #949

ChrisMaddock opened this issue May 9, 2021 · 2 comments · Fixed by #952
Assignees
Labels
Milestone

Comments

@ChrisMaddock
Copy link
Member

The nunit.engine.tests are currently failing to unload incorrectly on the master branch. I haven't had the time yet to bisect and find out where this crept in - if anyone else has the time to take a look, please feel free!

NUnit.Engine.NUnitEngineUnloadException : Agent Process was terminated successfully after error.
  ----> NUnit.Engine.NUnitEngineUnloadException : Exception encountered unloading application domain
  ----> NUnit.Engine.NUnitEngineException : Exception encountered unloading application domain: Error while unloading appdomain. (Exception from HRESULT: 0x80131015)
Application domain name: domain-
Application domain BaseDirectory: D:\a\1\s\bin\Release\net35\
Error trying to read application domain details: Could not load file or assembly 'nunit.engine, Version=3.13.0.0, Culture=neutral, PublicKeyToken=2638cd05610744eb' or one of its dependencies. The system cannot find the file specified.
@ChrisMaddock ChrisMaddock added this to the 3.13 milestone May 9, 2021
@ChrisMaddock
Copy link
Member Author

@CharliePoole this seems to have been introduced in #937. Would you mind taking a look and seeing if you can figure it out?

I can't see anything obvious myself - I wonder if the new TcpTransport class isn't disposed correctly in some test setup somewhere...

@ChrisMaddock
Copy link
Member Author

Never mind, I got there eventually! PR incoming. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants