Bug: StackOverflowException when test calls recursive method in 3.7.

[andrewimcclement]

Using .NET Framework 4.8.
This builds fine using NUnit.Analyzers 3.5.0 but fails in 3.7.0 (and 3.8.0):

using System;
using System.Collections.Generic;

using NUnit.Framework;

namespace Namespace
{
    internal class Fixture
    {
        private Dictionary<string, bool> _values = new Dictionary<string, bool>();

        [Test]
        public void MinimalRepro()
        {
            Recurse("help");
        }

        private void Recurse(string one, bool keepGoing=true)
        {
            _values[one] = keepGoing;
            if (keepGoing)
            {
                Recurse(one, false);
            }
        }
    }
}

Error looks like

I don't have time to actually debug the analyser right now but I hope this repro is small enough to make it easy.

[manfred-brands]

@andrewimcclement Thanks for reporting.

I think I know where the issue is, I just didn't think of recursion when implementing this.

[manfred-brands]

@andrewimcclement There are a few possible workarounds for you:

1. Disable NUnit1032 in the class with the recursive method(s) using: #pragma warning disable NUnit1032
2. Disable NUnit1032 for the whole project using: dotnet_diagnostic.NUnit1032.severity = none
3. Move the recursive method to a local function or nested class as the analyzer only checks methods in the same class.
4. Use the NuGet package created from the PR build artifacts

[andrewimcclement]

Thanks for the workarounds. I think I'll probably go with number 2 until a new version is out with the fix, as if it appears elsewhere, it is non-obvious what the fix is for other people in my team. Many thanks for the speedy investigation.