Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 'TargetFramework' property should not cause an Exception #37

Closed
synek317 opened this issue Feb 20, 2021 · 3 comments · Fixed by #51 or #52
Closed

Missing 'TargetFramework' property should not cause an Exception #37

synek317 opened this issue Feb 20, 2021 · 3 comments · Fixed by #51 or #52
Assignees
Labels
Milestone

Comments

@synek317
Copy link

synek317 commented Feb 20, 2021

Becuase of this line, if any csproj inside a solution uses <TargetFrameworks> instead of <TargetFramework>, running nunit3-consolle on whole solution raises an exception:

string targetFramework = _doc.SelectSingleNode("Project/PropertyGroup/TargetFramework").InnerText;

I'm not sure if the project is maintained or not but I believe the fix is pretty easy and seeing it fixed would really help.

@CharliePoole
Copy link
Contributor

CharliePoole commented Sep 19, 2021

NOTE: Deleted comment not actually intended for this issue!

@CharliePoole
Copy link
Contributor

This is fixed in the sense that you may now use TargetFrameworks rather than TargetFramework. However, only one runtime is actually supported. I did it this way because this fix is trivial and multiple runtime support will take more time. You can follow progress on multiple runtimes on issue #26

@CharliePoole
Copy link
Contributor

🎉 This issue has been resolved in version 3.9.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment