Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👔 Missing titles on sharing links for whatsapp and telegram #1669

Closed
infused-kim opened this issue Aug 9, 2024 · 0 comments · Fixed by #1767
Closed

👔 Missing titles on sharing links for whatsapp and telegram #1669

infused-kim opened this issue Aug 9, 2024 · 0 comments · Fixed by #1767
Labels
enhancement New feature or request

Comments

@infused-kim
Copy link

Hi,

First of all, thank you so much for creating this theme. Your eye for design is amazing and the code is so great and easily extendable.

Most people pick a site generator and then look for a theme... I did the opposite. I only picked Hugo, because I loved your theme so much! :)

Describe the bug
PR #659 added Whatsapp and Telegram sharing links, but the corresponding titles where not added in themes/blowfish/i18n/en.yaml.

This leads to a reduced accessiblity score from the Google Page Insights test.

Workaround
In i18n/en.yaml add:

sharing:
  whatsapp: "Share via WhatsApp"
  telegram: "Share via Telegram"

Screenshots
Screenshot 2024-08-08 at 20 04 42
Screenshot 2024-08-08 at 20 05 30

Hugo & Blowfish versions

  • Hugo: 0.87.0/0.128.2
  • Blowfish: 2.74.0
@nunocoracao nunocoracao changed the title Missing titles on sharing links for whatsapp and telegram 👔 Missing titles on sharing links for whatsapp and telegram Sep 3, 2024
@nunocoracao nunocoracao added the enhancement New feature or request label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants