Document errors to ignore instead of forcing it upon users #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spawnia
commented
May 6, 2020
spawnia
commented
May 6, 2020
spawnia
commented
May 6, 2020
|
Should we increase the minor version (0.6) when this is merged? |
Makes sense, there is some breakage that might require a bunch of work. Should i write up a quick upgrade guide? |
Yes, that would be nice. We can maybe redirect them to the actual docs in the upgrade guide. |
mfn
reviewed
May 7, 2020
canvural
requested changes
May 7, 2020
canvural
approved these changes
May 8, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added or updated testsRelates to the discussion in #557
Changes
Breaking changes
reportUnmatchedIgnoredErrors