-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for orWhere
HigherOrderBuilderProxy property
#884
Conversation
Very good-looking PR! |
2cd3a6d
to
366ea3d
Compare
The PR is ready to be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I just added one small correction review.
Indeed the errors seems not related to this PR. After you fix the review we can merge this.
366ea3d
to
e24ff5b
Compare
My mistake, it's moved! |
orWhere
HigherOrderBuilderProxy propertyorWhere
HigherOrderBuilderProxy property
Thank you! |
Sorry I forgot to change the commit message.... |
@canvural Any idea on failing CI? |
No. I didn't check it in detail yet. But a lot of stuff changed in 9.x Is it possible to tell Github Actions a workflow is allowed to fail? 9.x is still 6 months away and things can break anytime. |
This is a highly requested feature of GHA 😢 |
Changes
HigherOrderBuilderProxy property
orWhere
is not supported by Larastan yet.Closes #885