Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor can create diagram using textual representation #22

Closed
chuajiaxuan opened this issue Jan 26, 2017 · 3 comments
Closed

Editor can create diagram using textual representation #22

chuajiaxuan opened this issue Jan 26, 2017 · 3 comments
Assignees
@chuajiaxuan
Labels
us: us:6.MarkdownExtras
Milestone
V0.1.4

Comments

@chuajiaxuan
Copy link
Contributor

chuajiaxuan commented Jan 26, 2017 •
edited by amoshydra
Loading

Example: https://hackmd.io/features#uml-diagrams
@amoshydra amoshydra changed the title Editor shall be allowed to produce diagram using textual representation Editor can create diagram using textual representation Feb 1, 2017
@tayjiehao tayjiehao added this to the V0.1.2 milestone Feb 5, 2017
@amoshydra amoshydra assigned tayjiehao and chuajiaxuan and unassigned tayjiehao Feb 15, 2017
@chuajiaxuan
Copy link
Contributor Author

Hackmdio uses js-sequence-diagrams , mermaid and graphviz. Will need more research on how to implement this. Currently, there doesn't seem to be any markdown-it plugins.

@chuajiaxuan chuajiaxuan modified the milestones: V0.1.4, V0.1.2 Feb 24, 2017
@chuajiaxuan chuajiaxuan mentioned this issue Mar 19, 2017
Merged
@chuajiaxuan
Copy link
Contributor Author

This feature has been included! However, test cases for this component has met with a road block because HTML attribute values generated/drawn by diagramsRenderer will always be different due to "window size"/HTML document size. (e.g. 1. There are tags with specific ids attributes who values are randomly generated by the respective libraries. 2. Attributes such as "x", "y", "width", "height" etc have attribute values that differ based on the HTML Document object they are in. Hence, unit testing locally will produce different results then testing on travis, that is why travis keeps failing as well. To be resolved.)

@chuajiaxuan
Copy link
Contributor Author

Implemented in PR #336 already!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuajiaxuan chuajiaxuan

Labels
us: us:6.MarkdownExtras
Projects
None yet
Milestone
V0.1.4
Development

No branches or pull requests
3 participants
@amoshydra @tayjiehao @chuajiaxuan