Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mobility page for ISBs, MRT info #3675

Open
9 of 13 tasks
kagiura opened this issue Mar 20, 2024 · 5 comments · May be fixed by #3712
Open
9 of 13 tasks

Add Mobility page for ISBs, MRT info #3675

kagiura opened this issue Mar 20, 2024 · 5 comments · May be fixed by #3712
Labels
taken

Comments

@kagiura
Copy link

kagiura commented Mar 20, 2024 •
edited
Loading

https://github.com/kagiura/nusmods/tree/kagiura/mobility

TODO:
immediate:

  • replace with proxy API url
  • placeholders for when no bus data / no buses left today
  • svc E placeholder (make it show "resumes later today")
  • actually make it register if its term or holiday (in getServiceStatus (src/utils/mobility.ts))
  • update bus schedule
  • button to switch to opposite side stop
  • directional arrows for one way svc
  • optimize: use useCallback/useMemo
  • auto-switch to BTC when needed (and vice versa)
  • fix text font size for selected/focused stop

future:

  • show KR / BG MRT timings too why not
  • make it just use a normal polyline so its easier (?) to update when route changes
  • locate nearby classrooms
@ravern ravern changed the title Adding Mobility page for ISBs, MRT info Add Mobility page for ISBs, MRT info Mar 20, 2024
@ravern ravern added the taken label Mar 20, 2024
@kagiura
Copy link
Author

kagiura commented Mar 20, 2024

refactored a fck ton + this shows properly whether there actually is no more buses or there was an error
2024-03-20-17 44 49@2x

@kagiura
Copy link
Author

kagiura commented Mar 20, 2024

(also, its kind of annoying to take out the keys manually every time i wanna commit so ill wait until proxy api is set up before i continue with timings-related features haha)

@kagiura
Copy link
Author

kagiura commented Apr 8, 2024

(minor update: MRT timings do not exist as a public api in singapore :,)

@kagiura
Copy link
Author

kagiura commented Apr 8, 2024 •
edited
Loading

optimization checklist

  • MobilityContainer
  • SvcDetail
  • SvcList
  • StopDetail
  • LocationMap
  • ISBServices

@kokrui kokrui linked a pull request Apr 9, 2024 that will close this issue
Add Mobility page for ISBs, MRT info #3712
Open
@kagiura kagiura linked a pull request Apr 9, 2024 that will close this issue
Open
@aoi-ue
Copy link

aoi-ue commented Jun 14, 2024

@kagiura are those to-do fully completed? seems like the pipeline is failing because some build issue (cicd issue seems like it) would like to contribute on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
taken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Mobility page for ISBs, MRT info kagiura/nusmods
3 participants
@ravern @aoi-ue @kagiura