Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on irq_handler overwrite #50

Closed
Lurk opened this issue Nov 6, 2021 · 1 comment · Fixed by #53
Closed

Panic on irq_handler overwrite #50

Lurk opened this issue Nov 6, 2021 · 1 comment · Fixed by #53

Comments

@Lurk
Copy link
Contributor

Lurk commented Nov 6, 2021

Right now, after we switch to MaybeUninit, we lose panic on irq_handler overwrite. But now it is even more important than before because MaybeUninit::write will not drop the previous value so that Box will live forever. Or, if I overthink, and this is not the real problem, this should be documented as a feature :)

I will be happy to provide a PR.

@nuta
Copy link
Owner

nuta commented Nov 6, 2021

Sounds good improvement to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants