Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support meilisearch v1.1.x - Multi-index search #2

Closed
BlitzBanana opened this issue Mar 29, 2023 · 6 comments · Fixed by #5
Closed

Support meilisearch v1.1.x - Multi-index search #2

BlitzBanana opened this issue Mar 29, 2023 · 6 comments · Fixed by #5
Labels
enhancement New feature or request

Comments

@BlitzBanana
Copy link
Member

See: https://github.com/meilisearch/meilisearch/releases/tag/v1.1.0-rc.0

@BlitzBanana BlitzBanana added the enhancement New feature or request label Mar 29, 2023
@fredwu
Copy link
Contributor

fredwu commented May 21, 2023

Hi, I'm looking into using Meilisearch in my elixir project. Is this being actively worked on?

cc @ brunoocasali since you've previously offered help on robottokauf3/meilisearch-elixir#10

Thanks folks! 🙏

@BlitzBanana
Copy link
Member Author

@fredwu @brunoocasali

Hi,

First of all, thanks for your interest in this lib.

I'm using Meilisearch in production (0.25, then 1.0.x).
So, I started by forking https://github.com/robottokauf3/meilisearch-elixir to support 0.25.x and made a pull request.
It was eventually merged a year later, but in the meantime, I ended up creating my own lib https://github.com/nutshell-lab/meilisearch-ex for 1.0.0.

I'm using this in production, so, I would like to maintain it actively, but I lack the time to do it as soon as Meilisearch updates comes out.
That said, I will gladly accept pull requests and I will try to find the time to update to 1.2 new features.

@fredwu
Copy link
Contributor

fredwu commented May 22, 2023

@BlitzBanana Thanks mate!

I've started looking into implementing some of the new APIs, starting from multi-index (got it working). I've also noticed a few small things in the code base that could use some improvements.

I'll issue a PR when it's ready. :)

@brunoocasali
Copy link
Contributor

Hi @BlitzBanana and @fredwu!

That’s amazing to see the Elixir community taking care of that. Indeed I reached out robottokauf3 offering my help to make the work move forward on its side, but since I did not receive any official “reply” from him, I thought he didn’t have time to maintain it, and that’s perfectly fine.

Out of the blue, I’m not an Elixir expert, but I’m learning it in my spare time. And of course, I would love to have an Elixir integration, but I don’t have the time and knowledge to maintain one entirely.

If you agree on @BlitzBanana, I would love to make this repository like the other meilisearch integrations. Then in the future, we could move it to our Meilisearch organization if you agree, which could bring more awareness and improve the adoption of the library.
From the Meilisearch side, I could also map which feature is present or not regarding our releases (we have some automation for that).

@BlitzBanana
Copy link
Member Author

BlitzBanana commented May 24, 2023

Hi @brunoocasali

If you want to make a pull request to comply to the standards of other integrations, I will happily review & merge it.
I'm perfectly open to move the repo under Meilisearch organization in the future.

#6

@fredwu
Copy link
Contributor

fredwu commented May 24, 2023

Just chiming in to say that I'd love to pitch in to help too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants