-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to use IdToken instead of AccessToken #121
Conversation
docs/schemes/oauth2.md
Outdated
@@ -18,6 +18,7 @@ auth: { | |||
token_type: 'Bearer', | |||
redirect_uri: undefined, | |||
client_id: 'SET_ME', | |||
id_token: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default shouldn't be false
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. BTW what's your idea if we can generalize this option little more. Like having an option like tokenKey
(or something better. I'm not good at naming!) that can be id_token
/access_token
or anything else.
You're absolutely right, I've updated the commit. I like the idea of using |
@sschadwick Yep exactly what i was mean. Something like this: let token = parsedQuery[this.options.tokenKey] |
Okay updated again. I used your suggestion but changed |
Thanks for your contribution! |
#119