Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google not working with oauth2 server side callback #393

Closed
zsavajji opened this issue Jun 24, 2019 · 2 comments · Fixed by #394
Closed

Google not working with oauth2 server side callback #393

zsavajji opened this issue Jun 24, 2019 · 2 comments · Fixed by #394
Labels

Comments

@zsavajji
Copy link

Version

v4.8.0

Reproduction link

https://this-page-intentionally-left-blank.org/

Steps to reproduce

Upgrade to 4.8.0, try to login with Google oauth2.
In the callback url fetch method you'll have no auth data.

What is expected ?

To have the access_token available into $auth.getToken('google')

What is actually happening?

It's undefined

Additional comments?

What i can see, is that in the new server side callback url, the data gets extracted from the route without parsing the query:
const parsedQuery = Object.assign({}, this.$auth.ctx.route.query, this.$auth.ctx.route.hash)

This assignment returns an empty object in my case.

This bug report is available on Nuxt community (#c363)
@mmachatschek
Copy link
Contributor

Hey @zsavajji,

@pi0
I ran into the same issue. You were on the right track. I opened a PR #394 which should fix the problem.

Cheers

@pi0 pi0 closed this as completed in #394 Jun 24, 2019
@pi0
Copy link
Member

pi0 commented Jun 24, 2019

Landed in 4.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants