Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(defaults): set proper Accept-Encoding for server side #176

Merged
merged 4 commits into from
Nov 7, 2018
Merged

fix(defaults): set proper Accept-Encoding for server side #176

merged 4 commits into from
Nov 7, 2018

Conversation

jericopulvera
Copy link
Contributor

@jericopulvera jericopulvera commented Nov 5, 2018 •
edited by TheAlexLichter
Loading

Resolves #170

@jericopulvera jericopulvera reopened this Nov 5, 2018
@TheAlexLichter TheAlexLichter requested a review from pi0 November 5, 2018 08:18
@dohomi
Copy link

dohomi commented Nov 7, 2018

I had the exact same issue. Would be great being merged

pi0
pi0 reviewed Nov 7, 2018
View reviewed changes
@jericopulvera
Update plugin.template.js
422b8fd 
Don't set content-encoding if in browser
TheAlexLichter
TheAlexLichter suggested changes Nov 7, 2018
View reviewed changes
lib/plugin.template.js Outdated
}

if (process.server) {
headers['Accept-Encoding'] = 'gzip, deflate'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be in common I think 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manniL @pi0 don't know why but It didn't work for me when it's in common.

tried it locally.

@pi0 pi0 changed the title This pr fixes brotli gibberish response on server. fix(defaults): set proper Accept-Encoding for server side Nov 7, 2018
@pi0 pi0 merged commit c84fb56 into nuxt-community:dev Nov 7, 2018
@jericopulvera
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAlexLichter TheAlexLichter TheAlexLichter requested changes

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jericopulvera @dohomi @TheAlexLichter @pi0