Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use server of nuxt.config.js to set default baseURL #245

Merged
merged 1 commit into from
May 22, 2019
Merged

feat: use server of nuxt.config.js to set default baseURL #245

merged 1 commit into from
May 22, 2019

Conversation

ooookai
Copy link
Contributor

@ooookai ooookai commented May 3, 2019

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #245 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #245   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines        27     27           
  Branches     12     12           
===================================
  Hits         27     27
Impacted Files Coverage Δ
lib/module.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f744666...9e6f7c7. Read the comment docs.

@atinux atinux requested review from atinux, TheAlexLichter and pi0 May 21, 2019 15:27
atinux
atinux approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@atinux atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, cc @pi0 & @manniL

TheAlexLichter
TheAlexLichter approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@TheAlexLichter TheAlexLichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤔

@pi0 pi0 merged commit e1120a9 into nuxt-community:dev May 22, 2019
@pi0 pi0 mentioned this pull request Sep 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAlexLichter TheAlexLichter TheAlexLichter approved these changes

@atinux atinux atinux approved these changes

@pi0 pi0 Awaiting requested review from pi0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ooookai @TheAlexLichter @atinux @pi0