Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add missing type for create() #475

Merged
merged 2 commits into from
Feb 3, 2021
Merged

fix(types): add missing type for create() #475

merged 2 commits into from
Feb 3, 2021

Conversation

farnabaz
Copy link
Member

@farnabaz farnabaz commented Feb 3, 2021

Add missing type for create() function inside NuxtAxiosInstance

resolves #420

@farnabaz farnabaz requested a review from pi0 February 3, 2021 12:50
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #475 (2fcf37d) into master (a61b82b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #475   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files           1        1           
  Lines          51       51           
  Branches       27       27           
=======================================
  Hits           45       45           
  Misses          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a61b82b...3cb782e. Read the comment docs.

types/index.d.ts Outdated Show resolved Hide resolved
@pi0 pi0 merged commit 62f17ca into master Feb 3, 2021
@pi0 pi0 deleted the add-create-type branch February 3, 2021 13:00
This was referenced Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$axios.create() is of type AxiosInstance, not NuxtAxiosInstance.
2 participants