Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nuxt helpers #160

Merged
merged 8 commits into from
Jul 18, 2020
Merged

feat: add nuxt helpers #160

merged 8 commits into from
Jul 18, 2020

Conversation

mathe42
Copy link
Collaborator

@mathe42 mathe42 commented Jul 18, 2020

fixes #157

TODO:

  • Vuex
  • Docs
  • Tests (only types)

@vercel
Copy link

vercel bot commented Jul 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxt-community/composition-api/bakkj30u8
✅ Preview: https://composition-api-git-fork-mathe42-patch-2.nuxt-community.vercel.app

@mathe42 mathe42 changed the title feat: add createNuxt... helpers feat: add defineNuxt... helpers Jul 18, 2020
@vercel vercel bot temporarily deployed to Preview July 18, 2020 13:51 Inactive
@danielroe
Copy link
Member

Looking good. I think no need to add Vuex helpers as there are other projects for that, and it's not specific to Nuxt. I would simply add tests with tsd.

@mathe42
Copy link
Collaborator Author

mathe42 commented Jul 18, 2020

@danielroe I think you can merge this PR :D

@danielroe danielroe changed the title feat: add defineNuxt... helpers feat: add nuxt helpers Jul 18, 2020
@danielroe danielroe merged commit 8a9885e into nuxt-community:master Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: defineNuxtPlugin
2 participants