Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent useMeta from sharing state in ssr #268

Merged
merged 3 commits into from
Oct 14, 2020

Conversation

axelhzf
Copy link
Contributor

@axelhzf axelhzf commented Oct 14, 2020

Trying to fix #267

I removed the properties declared on the $options and declared them directly on the instance.

@vercel
Copy link

vercel bot commented Oct 14, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxt-community/composition-api/dkphe1dhv
✅ Preview: https://composition-api-git-fix-use-meta-ssr-shared-state.nuxt-community.vercel.app

@danielroe danielroe changed the title Fix useMeta ssr shared state fix: prevent useMeta from sharing state in ssr Oct 14, 2020
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @axelhzf - I appreciate this - looks good to me 😀

@danielroe danielroe merged commit e54cefe into nuxt-community:main Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: shared state on server-side computed useMeta
2 participants