Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add composition api helper to interact with head() #35

Merged
merged 5 commits into from
May 7, 2020
Merged

feat: add composition api helper to interact with head() #35

merged 5 commits into from
May 7, 2020

Conversation

mathe42
Copy link
Collaborator

@mathe42 mathe42 commented May 7, 2020

No description provided.

danielroe
danielroe requested changes May 7, 2020
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it. I do wonder if it would be better to rename getMeta to useMeta and the overall function could be useHead?

Also might be worth a couple of lines in meta-test-d.ts just confirming the expected types?

README.md Outdated Show resolved Hide resolved
test/fixture/pages/meta.vue Outdated Show resolved Hide resolved
@danielroe danielroe changed the title feat(meta): added useMeta feat: add composition api helper to interact with head() May 7, 2020
@mathe42 @danielroe
Apply suggestions from code review
36fa3b1 
Co-authored-by: Daniel Roe <daniel@roe.dev>
@danielroe danielroe added the enhancement New feature or request label May 7, 2020
@mathe42
Copy link
Collaborator Author

mathe42 commented May 7, 2020

@danielroe I changed the names as you suggested. 👍

danielroe
danielroe reviewed May 7, 2020
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@mathe42 @danielroe
Update src/index.ts
955d43b 
Co-authored-by: Daniel Roe <daniel@roe.dev>
danielroe
danielroe reviewed May 7, 2020
View reviewed changes
src/meta.ts Outdated Show resolved Hide resolved
@danielroe danielroe merged commit b7467e2 into nuxt-community:master May 7, 2020
@mathe42 mathe42 deleted the useMeta branch May 7, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe requested changes

Assignees

@mathe42 mathe42

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathe42 @danielroe