-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: build on Windows #377
fix: build on Windows #377
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nuxt-community/composition-api/2qk6r1hpE3apdt26WRb2aToLwc5x |
package.json
Outdated
@@ -67,6 +67,7 @@ | |||
"dependencies": { | |||
"@vue/composition-api": "1.0.0-rc.1", | |||
"defu": "^3.2.2", | |||
"rimraf": "^3.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move this to devDependencies
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be production dependency if I'm not mistaken. It will not only be used during development but also when used as a dependency, because yarn build
is ran during installation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why yarn build
is being run in your case. Perhaps it's wrongly triggered by the prepare
script - or maybe you have the package installed via GitHub rather than non. But regardless the build will fail without the other devdependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for this ❤️
(Also note rimfar for amusement.)
When
@nuxtjs/composition-api
is a dependency of a project, the installation always fails on Windows, because of UNIX commands.This PR replaces
rm -rf
with OS-agnostic libraryrimraf
.