feat: experimental vite support #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move remaining bastions to `upath` * use `options.alias` rather than extending webpack build
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nuxt-community/composition-api/72grcPvrdmjMhRnYjmigCQQnWfoJ |
* allow multiple installations of VCA in dev mode (for vite)
danielroe
commented
Mar 2, 2021
pi0
reviewed
Mar 2, 2021
src/module.ts
Outdated
| }) | ||
|
|
||
| // Fake alias to prevent shadowing actual node_module | ||
| const aliases = ['@nuxtjs/composition-api', '@nuxtjs/vite-composition-api'] |
There was a problem hiding this comment.
I think in case of using a sub-path this should not happen (we use nuxt3/build for example and is working fine)
|
Note: the final issue with |
pi0
reviewed
Mar 2, 2021
pi0
previously approved these changes
Mar 5, 2021
pi0
reviewed
Mar 5, 2021
pi0
approved these changes
Mar 5, 2021
This was referenced Mar 8, 2021
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can try this PR by installing
@nuxtjs/composition-api@viteand following the steps below.To use
@nuxtjs/composition-apiwithnuxt-viteyou must:@vue/composition-apias a top level devDependency of your project rather than relying on the version provided by@nuxtjs/composition-api.will close nuxt/vite#17