Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change how library is imported #418

Merged
merged 15 commits into from
Apr 2, 2021

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Mar 26, 2021

BREAKING CHANGE: @nuxtjs/composition-api/module is now how the module should be imported in nuxt.config

  • module exports are now identical in node versions with/without support for package.json exports. There are three public entrypoints:
    • @nuxtjs/composition-api/babel (for babel plugin which normally shouldn't be invoked by user)
    • @nuxtjs/composition-api/entrypoint (for jest config)
    • @nuxtjs/composition-api/module (the new module path, which MUST be updated in your nuxt.config)

This also solves a regression with using this module with nuxt-vite.

BREAKING CHANGE: `@nuxtjs/composition-api/module` is now how the module should be imported in `nuxt.config`

* module exports are now identical in node versions with/without support for package.json exports. There are three public entrypoints:
  - `@nuxtjs/composition-api/babel` (for babel plugin which normally shouldn't be invoked by user)
  - `@nuxtjs/composition-api/entrypoint` (for jest config)
  - `@nuxtjs/composition-api/module` (the new module path, which MUST be updated in your `nuxt.config`)
@vercel
Copy link

vercel bot commented Mar 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxt-community/composition-api/Au9PYMhV9F8pHeeGMgZNuRfjKE4B
✅ Preview: Failed

[Deployment for 0042b9a failed]

@danielroe danielroe requested a review from pi0 March 30, 2021 14:18
renovate bot and others added 12 commits April 2, 2021 13:53
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
BREAKING CHANGE: `@vue/composition-api` is no longer transpiled by default - in addition, ensure you haven't named any layout '0'

Previously `@vue/composition-api` was transpiled which led to problems depending on other libraries (namely, they had to be added to `build.transpile` to work - see #429 for summary). This fixes that issue (and solves #415 properly)

This uses a hack to solve that, by using a _layout_ to register Vue Composition API. (By using a key of '0' it ensures that it appears first in `Object.keys` ahead of any other layout, although users should ensure they haven't named any layout '0'.)

**Key notes**:
* `@vue/composition-api` is yet again a runtime dependency - so do add it separately to your `dependencies` or add it back into `build.transpile` if that's appropriate for your situation.

reverts #391
@danielroe danielroe merged commit 5bb1a72 into main Apr 2, 2021
@danielroe danielroe deleted the backwards-node-compatibility branch April 2, 2021 13:04
danielroe added a commit that referenced this pull request Apr 2, 2021
@danielroe danielroe mentioned this pull request Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant