Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): export default from register entry #461

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Apr 21, 2021

As a result of 9d4165a, this line is being added to middleware.js

import $c289ad42 from './composition-api/register.js'

Which fails on vite since register.js is not exporting any default.

For a longer run, I HIGHLY recommend avoiding this workaround for ordering and adding register.js to build entry

@danielroe danielroe merged commit e491722 into main Apr 21, 2021
@danielroe danielroe deleted the fix/register branch April 21, 2021 09:54
@hojas
Copy link

hojas commented Apr 23, 2021

+1, When to release this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants