Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve to single vue instance #525

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Conversation

danielroe
Copy link
Member

This PR aliases vue to a single Vue instance, required when using other libraries that resolve vue differently. Normally this would have just added bytes to the bundle, but because of how the composition API is implemented, it breaks reactivity.

resolves #507, resolves #521

@danielroe danielroe self-assigned this Jul 27, 2021
@danielroe danielroe added the bug Something isn't working label Jul 27, 2021
@danielroe danielroe merged commit 33171bf into main Jul 28, 2021
@danielroe danielroe deleted the fix/resolve-single-vue-instance branch July 28, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

help: exported computed property is not reactive fix: two versions of vue included in app
1 participant