Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ssrRef and useAsync do not support HMR #88

Closed
danielroe opened this issue Jun 2, 2020 · 0 comments
Closed

fix: ssrRef and useAsync do not support HMR #88

danielroe opened this issue Jun 2, 2020 · 0 comments
Assignees
@danielroe
Labels
bug Something isn't working

Comments

@danielroe
Copy link
Member

danielroe commented Jun 2, 2020 •
edited
Loading

🐛 The bug
On hot module reloading in development, ssrRef factory functions will not be re-run.

🛠️ To reproduce

  1. git clone https://github.com/danielroe/repro-hmr-composition-api
  2. cd repro-hmr-composition-api && yarn && yarn dev
  3. Visit http://localhost:3000/api
  4. Edit ~/content/index.md
  5. (Contrast http://localhost:3000/vanilla.)

🌈 Expected behaviour
I would expect HMR to trigger a refresh of the factory function on client-side.

ℹ️ Additional context
See nuxt/content#80
@danielroe danielroe added the bug Something isn't working label Jun 2, 2020
@danielroe danielroe self-assigned this Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielroe danielroe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielroe