-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: font flickers when changing page #21
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 39 40 +1
Branches 11 11
=========================================
+ Hits 39 40 +1
Continue to review full report at Codecov.
|
Guys any guess on when this PR will be merged? I am thinking of using this module instead of the one I have in place but I can't do that before the flicker is fixed! Great module by the way =) |
@bissolli awaiting review.. |
@bissolli need analyze, it seems not to be working in production |
Merging as a hot fix now and releasing to at least fix the flicker. But I am not happy about having this: https://github.com/nuxt-community/google-fonts-module/blob/master/lib/module.js#L80-L82 And I believe we should work on v1.2 including #22 :) |
@atinux I agree |
Resolve #20
Disable reactivity on link
https://vue-meta.nuxtjs.org/api/#once