Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: font flickers when changing page #21

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

ricardogobbosouza
Copy link
Collaborator

@ricardogobbosouza ricardogobbosouza commented Oct 15, 2020

Resolve #20

Disable reactivity on link
https://vue-meta.nuxtjs.org/api/#once

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           39        40    +1     
  Branches        11        11           
=========================================
+ Hits            39        40    +1     
Impacted Files Coverage Δ
lib/module.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9687257...3203d00. Read the comment docs.

@atinux
Copy link
Contributor

atinux commented Oct 16, 2020

I think we should also implement font-display like @pi0 commented on #22

@bissolli
Copy link

Guys any guess on when this PR will be merged? I am thinking of using this module instead of the one I have in place but I can't do that before the flicker is fixed!

Great module by the way =)

@ricardogobbosouza
Copy link
Collaborator Author

I think we should also implement font-display like @pi0 commented on #22

@atinux better to create in another PR, no?

@ricardogobbosouza
Copy link
Collaborator Author

Guys any guess on when this PR will be merged? I am thinking of using this module instead of the one I have in place but I can't do that before the flicker is fixed!

Great module by the way =)

@bissolli awaiting review..

@ricardogobbosouza
Copy link
Collaborator Author

@bissolli need analyze, it seems not to be working in production
#20 (comment)

@atinux atinux merged commit a992792 into master Oct 20, 2020
@atinux
Copy link
Contributor

atinux commented Oct 20, 2020

Merging as a hot fix now and releasing to at least fix the flicker.

But I am not happy about having this: https://github.com/nuxt-community/google-fonts-module/blob/master/lib/module.js#L80-L82

And I believe we should work on v1.2 including #22 :)

@atinux atinux deleted the fix-font-flickers-when-changing-page branch October 20, 2020 15:50
@ricardogobbosouza
Copy link
Collaborator Author

@atinux I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font flickers when changing page
3 participants