Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crossorigin has invalid value "true" #27

Closed
borisdayma opened this issue Nov 6, 2020 · 2 comments · Fixed by #28
Closed

crossorigin has invalid value "true" #27

borisdayma opened this issue Nov 6, 2020 · 2 comments · Fixed by #28

Comments

@borisdayma
Copy link
Contributor

I believe there is an error at this line.

It raises an error with html-validator:

error Attribute "crossorigin" has invalid value "true" attribute-allowed-values

The rendered element is:
<link data-n-head="ssr" data-hid="gf-preconnect" rel="preconnect" href="https://fonts.gstatic.com/" crossorigin="true">

It should be:
<link data-n-head="ssr" data-hid="gf-preconnect" rel="preconnect" href="https://fonts.gstatic.com/" crossorigin>

borisdayma added a commit to borisdayma/google-fonts-module that referenced this issue Nov 6, 2020
@andrejsharapov
Copy link

after update HTML validation errors found for /articles/ error: Attribute "crossorigin" should omit value (attribute-empty-style)

@borisdayma
Copy link
Contributor Author

According to this page, the empty string is valid but it's true that html-validator still complains.

An alternative would be to set it to anonymous which seems to also be equivalent according to the same page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants