feat: add preconnect hint for Google Fonts stylesheet #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 42 43 +1
Branches 13 13
=========================================
+ Hits 42 43 +1
Continue to review full report at Codecov.
|
danielroe
approved these changes
Jun 8, 2022
danielroe
reviewed
Jun 8, 2022
danielroe
reviewed
Jun 8, 2022
This commit adds a <link rel="preconnect" /> resource hint for the origin of the font stylesheet if the preconnect option is enabled. This is necessary because the font stylesheet and the font itself are served from two separate origins and both should be pre- connected. See https://web.dev/font-best-practices/#preconnect-to-critical-third-party-origins for more information.
|
@danielroe Thanks for the review! Comments should be addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a resource
hint for the origin of the font stylesheet if the
preconnect option is enabled. This is necessary
because the font stylesheet and the font itself are
served from two separate origins and both should be pre-
connected.
See https://web.dev/font-best-practices/#preconnect-to-critical-third-party-origins for more information.