Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: turn off preload tag option by default #86

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

kara
Copy link
Contributor

@kara kara commented Jun 8, 2022

This commit turns off preload tag generation for
Google Fonts by default because:

  • generally preconnect tags should be sufficient
  • adding preloads as well runs the risk of resource
    contention with more critical resources
  • preloads don't take into account font unicode
    ranges, which could be problematic for i18n

See more here: https://web.dev/font-best-practices/#avoid-using-preload-to-load-fonts

@danielroe danielroe changed the title fix: turn off preload tag option by default fix!: turn off preload tag option by default Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #86 (bb8c6f2) into master (bb8c6f2) will not change coverage.
The diff coverage is n/a.

❗ Current head bb8c6f2 differs from pull request most recent head 174bfa5. Consider uploading reports for the commit 174bfa5 to get more accurate results

@@            Coverage Diff            @@
##            master       #86   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           43        43           
  Branches        13        13           
=========================================
  Hits            43        43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb8c6f2...174bfa5. Read the comment docs.

This commit turns off preload tag generation for
Google Fonts by default because:
  - generally preconnect tags should be sufficient
  - adding preloads as well runs the risk of resource
    contention with more critical resources
  - preloads don't take into account font unicode
    ranges, which could be problematic for i18n

See more here: https://web.dev/font-best-practices/#avoid-using-preload-to-load-fonts
@ricardogobbosouza ricardogobbosouza merged commit fa4d4e0 into nuxt-modules:master Jun 9, 2022
@ricardogobbosouza
Copy link
Collaborator

Thanks @kara

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants