-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add support for nuxt 3/nuxt bridge #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Main issue is differences between vue-meta & vueuse/head. (Which may not be an issue with this module - partial support is better than none at all, and a console log may be enough to let user know until upstream features land.)
This is in draft but checking your todo list seems ready to be used, can we have an alpha version or something to don't use a github "link" in our package json? EDIT: Meanwhile we wait for a version this is how I was able to make it work...
nuxt.config.ts
modules/fonts.ts (first attempt)
The result is an error because the original package json is not exporting this file. modules/fonts.ts (second attempt)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I think you could possibly simplify things slightly by wrt nuxt 2/3 and injecting head, maybe with a helper function, if you wanted to. But that's only a nitpick.
This PR enables this module to work for Nuxt Bridge & Nuxt 3.
🔥 Notable changes
@nuxt/module-builder
to build module@nuxt/kit