Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: node-libs-browser being imported on the client #936

Merged
merged 2 commits into from
Oct 19, 2020
Merged

fix: node-libs-browser being imported on the client #936

merged 2 commits into from
Oct 19, 2020

Conversation

janKollars
Copy link

fixes #935 node-libs-browser being imported

replace deepcopy with lodash deepclone
c146bf6 
fixes node-libs-browser being imported
@rchl
Copy link
Collaborator

rchl commented Oct 19, 2020

Thanks. Will merge once you fix the package URL.

@rchl
Copy link
Collaborator

rchl commented Oct 19, 2020 •
edited
Loading

I suppose also:
Resolves #907

@rchl rchl changed the title replace deepcopy with lodash deepclone fix: node-libs-browser being imported on the client Oct 19, 2020
@rchl rchl merged commit 7490ae9 into nuxt-modules:master Oct 19, 2020
@janKollars
Copy link
Author

Thank you for fixing it! How embarrassing

@rchl
Copy link
Collaborator

rchl commented Oct 20, 2020

Thank you for finding and figuring out the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node-libs-browser included in bundle
2 participants
@janKollars @rchl