fix(google-tag-manager): fix respectDoNotTrack #295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition for initializing page tracking doesn't work properly:
Using
&&
everywhere means that settingrespectDoNotTrack
to true will prevent the entire condition from ever resolving totrue
, even if the user does not have the "do not track" setting totrue
.Setting
respectDoNotTrack
totrue
means that the condition will only resolve totrue
if the user disables "dot not track" (and thus means that the user's "do not track" setting is then respected)