Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programmatically create _redirects file through JS objects #4

Closed
TheAlexLichter opened this issue Jul 25, 2019 · 4 comments · Fixed by #11
Closed

Programmatically create _redirects file through JS objects #4

TheAlexLichter opened this issue Jul 25, 2019 · 4 comments · Fixed by #11

Comments

@TheAlexLichter
Copy link
Member

No description provided.

@andre-brdoch
Copy link
Contributor

@manniL Is there still need for this feature? I'd be willing to make a PR :)

Also, another netlify file that might be needed is netlify.toml. For this one, the option to create it programmatically also makes sense.

@TheAlexLichter
Copy link
Member Author

Hey @andre-brdoch 👋🏻

Yes, this feature is still desired 😋

Also, another netlify file that might be needed is netlify.toml. For this one, the option to create it programmatically also makes sense.

Definitely! Maybe we could focus on netlify.toml in general (instead of _redirects and _headers because they could be "transformed" into a netlify toml).

@andre-brdoch
Copy link
Contributor

Hey @manniL, i made a PR 😄 Let me know what you think: #11

allowing all 3 types of netlify files to be either copied or created programmatically might still make sense though, even though everything could be done via toml file. However, might get a little messy with the configurations, not sure what would be the best approach.

@TheAlexLichter
Copy link
Member Author

Thanks for the effort! Will check out in the coming days 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants