-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom block types inlined in Portable Text #216
Conversation
Sanity now supports custom inline blocks!
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 95.07% 95.60% +0.53%
==========================================
Files 8 8
Lines 203 205 +2
Branches 84 87 +3
==========================================
+ Hits 193 196 +3
+ Misses 10 9 -1
Continue to review full report at Codecov.
|
This looks great! Would you add a test + snapshot to cover possible options in the line you edited? For example: |
Done! I wrote a customLink component as an example but decided to keep it simple and didn't include. Code below if helpful.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you ❤️
Sanity now supports inline custom objects/_types!
This may not be the best way to achieve this
I've added another layer of testing the _type for custom serializers before finally testing the Marks.