Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly use q prop in <SanityImage> #52

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

liqueflies
Copy link
Contributor

I was trying to change quality of image, but q was missing on keys map.

I was trying to change quality of image, but `q` was missing on keys map.
@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #52 (b64f20e) into main (019fddf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files           6        6           
  Lines         204      204           
  Branches       78       78           
=======================================
  Hits          184      184           
  Misses         19       19           
  Partials        1        1           
Impacted Files Coverage Δ
src/components/sanity-image.ts 94.28% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 019fddf...b64f20e. Read the comment docs.

@danielroe
Copy link
Collaborator

Great spot - thanks! ❤️

@danielroe danielroe changed the title fix: missing q props into keys fix: correctly use q prop in <SanityImage> Nov 18, 2020
@danielroe danielroe merged commit 7f5eeba into nuxt-modules:main Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants