Skip to content

Commit

Permalink
fix: use core-js@3 for storybook build
Browse files Browse the repository at this point in the history
  • Loading branch information
@farnabaz
farnabaz committed Aug 2, 2020
1 parent 72c2044 commit 4f33618
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/index.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ async function buildNuxt (options: StorybookOptions) {
ssr: false,
buildDir,
build: {
corejs: '3',
extractCSS: false
}
},
Expand Down

4 comments on commit 4f33618

@pi0
Copy link

@pi0 pi0 commented on 4f33618 Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is implying that users have to use corejs3 regardless of nuxt version. Since maybe should also update docs to clarify? (since default installed version is still 2)

@lloydjatkinson
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just hit this problem - is it really necessary to make the user install this? Why not install it automatically?

@pi0
Copy link

@pi0 pi0 commented on 4f33618 Aug 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change for nuxt2 unfortunately 🙁 However we may use corejs3 by default with CNA or mentioning in storybook docs

@farnabaz
Copy link
Collaborator Author

@farnabaz farnabaz commented on 4f33618 Aug 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is implying that users have to use corejs3 regardless of nuxt version. Since maybe should also update docs to clarify? (since default installed version is still 2)

Is it required for users to add core-js@3? core-js@3 is a direct dependency on @storybook/vue.

Please sign in to comment.