Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicated border-2 class from copy-box #221

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

mattycraig
Copy link
Contributor

@mattycraig mattycraig commented Dec 4, 2020

boxClasses() already implements a border-2 class by default.

Some background as to why this change matters:

I'm using @nuxtjs/html-validator (https://html-validator.nuxtjs.org/) in a project, and the package is also validating the ./_tailwind colors page, thus giving me a duplicated border-2 class error message on the copy-box div.

As a side question: Is there a way to possibly turn off the generation of the colors via this module?

boxClasses() already implements a border-2 class by default
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #221 (19703a6) into master (15e1c43) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #221   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           43        43           
  Branches         9         9           
=========================================
  Hits            43        43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15e1c43...19703a6. Read the comment docs.

@atinux atinux changed the title Remove duplicated border-2 class from copy-box fix: remove duplicated border-2 class from copy-box Dec 4, 2020
@atinux
Copy link
Collaborator

atinux commented Dec 4, 2020

Thanks @mattycraig

Regarding the way to disable it, could you open an issue about this and the reason why please? :)

@atinux atinux merged commit c84c8be into nuxt-modules:master Dec 4, 2020
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants