fix(core): generate es exports dts files correctly #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Versions
Reproduction
Steps to reproduce
package.json
export schema:siroc build
What is Expected?
What is actually happening?
This prevents TypeScript from picking up definition files correctly, filling the
types
field on thepackage.json
file only fixes the top-level definition file.Patch
I extended the RegExp to optionally replace
.es
suffixes if present, fixing the issue.Checklist:
ps: that'd be cool if you can also check #211, it's been a month and with this one those are two quick patches, let me know how I can help if needed :(
cc @pi0, @danielroe, @angeloashmore