Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: regression on nuxt@3.13.2 breaking the entire module #80

Closed
tobychidi opened this issue Sep 16, 2024 · 16 comments · Fixed by nuxt/nuxt#29036
Closed

bug: regression on nuxt@3.13.2 breaking the entire module #80

tobychidi opened this issue Sep 16, 2024 · 16 comments · Fixed by nuxt/nuxt#29036
Labels
bug Something isn't working

Comments

@tobychidi
Copy link

The requested module '/nuxt/@fs/C:/Users/tobychidi/Documents/GitHub/kaycee/Rotabliss/node_modules/.pnpm/@vue-leaflet+vue-leaflet@0.10.1@types+leaflet@1.9.12_leaflet@1.9.4_typescript@5.6.2/node_modules/@vue-leaflet/vue-leaflet/dist/vue-leaflet.cjs.js?v=6cbe18fd' does not provide an export named 'LTileLayer'

image

@Gugustinette
Copy link
Collaborator

Ooh that's weird, can you provide a reproduction ?

@Gugustinette Gugustinette added the bug Something isn't working label Sep 16, 2024
@urbgimtam
Copy link

Suffering the same after updating to nuxt@3.13.2.

Reproduction

@urbgimtam
Copy link

Forcing nuxt@3.13.1 does not trigger error. Only 3.13.2

@cesxhin
Copy link

cesxhin commented Sep 16, 2024

same problem, after updating to nuxt@3.13.2

@Gugustinette
Copy link
Collaborator

After further investigations, I think this is more or less due to this fix from nuxt@3.13.2.

But I'm really not sure what should be changed on the module side, this is how components from vue-leaflet are imported :

for (const component of components) {
  addComponent({
    name: component,
    export: component,
    filePath: '@vue-leaflet/vue-leaflet',
    chunkName: `nuxt-leaflet/${component}`,
    mode: 'all',
  })
}

@danielroe any suggestion on this ?

You can develop on the module playground directly here : https://stackblitz.com/~/github.com/nuxt-modules/leaflet and try to navigate to /map/map path, which displays the following error :
Capture d’écran 2024-09-17 à 14 36 20

@danielroe
Copy link
Collaborator

yes, this is a nuxt bug.

@Gugustinette
Copy link
Collaborator

Re-opening until the fix is released, for now stick with nuxt@3.13.1

@Gugustinette Gugustinette reopened this Sep 17, 2024
@ipanamski
Copy link

Is the fix going to be included in the next release or the current one 3.13.2?

@Gugustinette
Copy link
Collaborator

@ipanamski You'll have to wait for a new release, I'll update this issue when it is available 👍

@urbgimtam
Copy link

It may be interesting to remind that it can be mitigated by wrapping <NuxtErrorBoundary> around your component which holds <LMap>, and even pass alternative content with <template #error={error}></template>.

Never used NuxtErrorBoundary much, but its really interesting as it can save the page from breaking in these kind of scenarios. Lovely stuff!

@Gugustinette Gugustinette changed the title Requested module 'LTileLayer' not found after Nuxt update bug: regression on nuxt@3.13.2 breaking the entire module Sep 21, 2024
@Gugustinette
Copy link
Collaborator

Gugustinette commented Sep 26, 2024

Looks like this will be fixed on v3.14.0 : nuxt/nuxt#29077

@Gugustinette
Copy link
Collaborator

Nuxt v3.14.0 was released, and Nuxt Leaflet 1.2.4 should be updated with it 👍

@Gugustinette
Copy link
Collaborator

As far as I tested, this seems resolved with Nuxt Leaflet 1.2.4.

@tobychidi can you confirm ?

@Niki2k1
Copy link

Niki2k1 commented Nov 4, 2024

Not op but I can confirm, works with 3.14 on my end 👍🏼

@tobychidi
Copy link
Author

The issue has been resolved. Thank you @Gugustinette

@Gugustinette
Copy link
Collaborator

Cool ! Thanks a lot everyone 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants