-
Notifications
You must be signed in to change notification settings - Fork 179
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(resolvers): respect configPath over layers
- Loading branch information
Showing
1 changed file
with
30 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7fe392
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the motivation behind this change? With this change my projects don't override their base layer's theme extension anymore 🤔
Having this on a base layer:
and this on the actual project:
shows yellow instead of overriding it with red after v
6.11.1
.c7fe392
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dargmuesli this change was important to prepare for #795; it makes sense semantically to use moduleOptions over layer[0], because like nuxt/ui uses installModule and it wouldn't have worked otherwise.
I think I see what caused your issue though, thanks for reporting - instead of mainPaths.push, we're looking at mainPaths.unshift - let me fix that or you can open a PR in that time!
c7fe392
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dargmuesli fix made. Can you try out nightly and confirm please, will release then.
c7fe392
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ineshbose yes, the nightly fixes the issue for me! ❤️ Thank you!