Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rewrite with module-builder and nuxt/kit #419

Merged
merged 11 commits into from
Feb 7, 2022

Conversation

pi0
Copy link
Contributor

@pi0 pi0 commented Feb 7, 2022

Follow-up from #399

  • Migrate to module-builder
  • Use @nuxt/kit for module definition
  • Working with Nuxt 3 (Vite and Webpack)
  • Config viewer
  • Expose config support
  • Remove CJS usage
  • Working with Nuxt 2 and bridge

Migration notes:

  • ~tailwind.config alias renamed to #tailwind-config
  • tailwindcss:config hook is being called when modules are being installed for more predictable building behavior. Any module extending tailwind config should be installed before tailwindcss module

Internal notes:

  • Config viewer is now an inline middleware to reduce complexity with nitro dev server support
  • Caching and chunk optimizations for #tailwind-config are dropped for now until finding a universal solution for JSON
  • Tests skipped for now until having test-utils for Nuxt3
  • nuxt.config.js is not added to content[] array as has issues with Nuxt3 import protection

@pi0 pi0 marked this pull request as draft February 7, 2022 19:22
@pi0 pi0 changed the title refactor: migrate to module-builder and nuxt/kit refactor: rewrite with module-builder and nuxt/kit Feb 7, 2022
@pi0 pi0 requested a review from atinux February 7, 2022 23:31
@pi0 pi0 marked this pull request as ready for review February 7, 2022 23:31
@pi0 pi0 changed the title refactor: rewrite with module-builder and nuxt/kit refactor!: rewrite with module-builder and nuxt/kit Feb 7, 2022
@pi0 pi0 merged commit 8ce8255 into main Feb 7, 2022
@pi0 pi0 deleted the refactor/module-builder branch February 7, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant