Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(script): wait for mount again #344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(script): wait for mount again #344

wants to merge 1 commit into from

Conversation

dargmuesli
Copy link
Collaborator

🔗 Linked issue

Resolves #342

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

@dargmuesli dargmuesli mentioned this pull request Oct 14, 2024
Open
danielroe
danielroe reviewed Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way we can add a regression test here? 🙏

@dargmuesli
Copy link
Collaborator Author

Should be possible by adding Turnstile to the subpage in the playground, but I'm currently too time limited to tinker with it. I haven't used Nuxt test utils before so it'd likely take me some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dargmuesli @danielroe