Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Add UI Framework: Framevuerk #291

Merged
merged 9 commits into from
Jul 26, 2019
Merged

Conversation

nainemom
Copy link
Contributor

@nainemom nainemom commented Jul 19, 2019

Framevuerk is a Fast, Responsive, Without Dependencies, Both Direction Support and Configurable (before run-time) UI Framework based on Vue.js. I've created a simple template using Framevuerk and add an option to select it in the saofile.js.

I didn't commit npm run test changes to index.test.js.* files. Maybe you should doing that?

Framevuerk docs and demo:
https://framevuerk.com

Framevuerk source on github:
https://github.com/framevuerk/framevuerk

Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr, looks all good except some tiny suggestions as my comments.

@clarkdo
Copy link
Member

clarkdo commented Jul 26, 2019

Could you please resolve the conflict ?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@nainemom
Copy link
Contributor Author

done.
should I commit npm run test changes to index.test.js.* files?

@clarkdo
Copy link
Member

clarkdo commented Jul 26, 2019

No worries, I'll fix for you, thanks for the contribution!

@clarkdo clarkdo merged commit db8441e into nuxt:master Jul 26, 2019
@nainemom
Copy link
Contributor Author

nainemom commented Jul 27, 2019

@clarkdo Thx for merging :)
But unfortunately, you miss mentioning Framevuerk in README.md file. Should I do special action for that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants