Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e tests are configured with project's nuxt.config #670

Merged
merged 3 commits into from
Dec 23, 2020

Conversation

Juice10
Copy link
Contributor

@Juice10 Juice10 commented Nov 30, 2020

End to end tests should be as close to the real thing as possible, re-creating a whole separate Nuxt configuration from scratch adds potential for inconsistencies.

Context

Being new to Nuxt I was bashing my head against why Nuxt e2e tests didn't have $axios configured, and why my project would fail to evaluate the components I referenced in layout files.
I also noticed that global css didn't work.
All of this because the nuxt.config.js wasn't being referenced in the end to end tests.

End to end tests should be as close to the real thing as possible, re-creating a whole separate Nuxt configuration from scratch adds potential for inconsistencies.
@Juice10 Juice10 changed the title Configure e2e tests with Nuxt configuration Fix: Configure e2e tests with Nuxt configuration Nov 30, 2020
@Juice10 Juice10 changed the title Fix: Configure e2e tests with Nuxt configuration Fix: Set e2e tests to be configured with project's nuxt.config Nov 30, 2020
@Juice10 Juice10 changed the title Fix: Set e2e tests to be configured with project's nuxt.config Fix: e2e tests are configured with project's nuxt.config Nov 30, 2020
@Juice10 Juice10 changed the title Fix: e2e tests are configured with project's nuxt.config fix: e2e tests are configured with project's nuxt.config Nov 30, 2020
@clarkdo
Copy link
Member

clarkdo commented Dec 23, 2020

Thanks.

@clarkdo clarkdo merged commit be14839 into nuxt:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants