Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cna-template): use npx to invoke locally installed binaries #774

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

jamesgeorge007
Copy link
Contributor

Follow up of #715

Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide more details about this? I don’t think every user has npx installed

@jamesgeorge007
Copy link
Contributor Author

Say; the user opts for npm as the package manager.

const pmRun = this.answers.pm === 'yarn' ? 'yarn' : 'npm run'

npm run would be substituted here. However, there isn't a corresponding script as part of the template.

Since npm v5.2.0 npx is pre-bundled with npm.

https://github.com/typicode/husky/tree/main/docs#locally-installed-binaries

@jamesgeorge007 jamesgeorge007 requested a review from clarkdo April 18, 2021 19:15
@clarkdo clarkdo merged commit a9844ee into nuxt:master Apr 21, 2021
@jamesgeorge007 jamesgeorge007 deleted the hotfix/cna-template branch April 21, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants