Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

feat: add type definitions #8

Merged
merged 2 commits into from
Jun 4, 2019
Merged

Conversation

potato4d
Copy link
Contributor

About

Write type definition.

Changes

  • Install @types/execa
  • Write types/lmify.d.ts

Note

It may be better to test with TypeScript to ensure type integrity.

types/lmify.d.ts Outdated Show resolved Hide resolved
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @potato4d!

@potato4d
Copy link
Contributor Author

@pi0
thank you your review.
resolved.

@potato4d
Copy link
Contributor Author

potato4d commented Jun 4, 2019

@pi0
Is there anything else I need to do?

@pi0 pi0 changed the title (types): Add Lmify type definition feat: add type definitions Jun 4, 2019
@pi0 pi0 merged commit 84eb206 into unjs:master Jun 4, 2019
@pi0
Copy link
Member

pi0 commented Jun 4, 2019

Thank you @potato4d. Sorry, my notifications were so messy and missed your comment :(

Types are available in 0.2.1.

@potato4d
Copy link
Contributor Author

potato4d commented Jun 4, 2019

@pi0
I was a little worried about my problem with the fix. lol
Thank you for merging!

@potato4d potato4d deleted the types/add-typedef branch June 4, 2019 10:33
@potato4d potato4d restored the types/add-typedef branch June 4, 2019 10:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants