Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[edge] latest edge version breaks useFetch in composition API module #8781

Closed
manniL opened this issue Feb 7, 2021 · 2 comments · Fixed by nuxt-community/composition-api#366
Closed

[edge] latest edge version breaks useFetch in composition API module #8781

manniL opened this issue Feb 7, 2021 · 2 comments · Fixed by nuxt-community/composition-api#366
Assignees
@danielroe
Labels
2.x pending triage

Comments

@manniL
Copy link
Member

manniL commented Feb 7, 2021 •
edited
Loading

Cross-linking nuxt-community/composition-api#364 here for visibility / awareness (because the root cause could trigger errors in other scenarios as well) ☺️

Last working version: nuxt-edge@2.15.0-26802759.5a5161aa
First broken version: nuxt-edge@2.15.0-26807078.b06df717

Related commit: 92018e5

Please check the linked issue for repro + error scenario.
@danielroe Volta.net
Copy link
Member

Potential backwards compatibility would be to define a push function on the object.

But I think this is an internal API and I am not sure we need to do anything apart from updating the NCA plugin. Thoughts?

@danielroe danielroe self-assigned this Feb 7, 2021
@manniL
Copy link
Member Author

manniL commented Feb 7, 2021

If we can update NCA without breaking changes this’d probably be fine 👍🏼

@danielroe danielroe mentioned this issue Feb 11, 2021
Merged
danielroe added a commit to nuxt-community/composition-api that referenced this issue Feb 14, 2021
@danielroe
feat: fetch improvements (#366)
d4bdbfb 
* feat: support new fetchKey (Nuxt 2.15+) - closes #364, nuxt/nuxt#8781
* fix: fix issue with refetching/hydration in full static mode - closes #292
* fix: align fetch keys with 2.15 - see nuxt/nuxt#8809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielroe danielroe

Labels
2.x pending triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: fetch improvements nuxt-community/composition-api
2 participants
@manniL @danielroe