-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webpack): suppress not found typescript warnings #5635
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5635 +/- ##
==========================================
+ Coverage 95.57% 95.58% +0.01%
==========================================
Files 81 82 +1
Lines 2645 2653 +8
Branches 673 677 +4
==========================================
+ Hits 2528 2536 +8
Misses 98 98
Partials 19 19
Continue to review full report at Codecov.
|
Hi @Yama-Tomo, thanks for your work ! I'm not really a fan of such plugins suppressing warnings, so ideally I'd prefer an use case where the warnings are not fixable and would showcase the need of this. Could you maybe provide some reproduction where these warnings are persisting in a Nuxt project ? |
@kevinmarrec Thanks for your comment! Here is code for my boilerplate for nuxt project. How to reproduction
or
|
@Yama-Tomo Hm alright, seems to be really specific case. IMO I don't think that such "suppress warning" feature should be included in Nuxt core, I mean for specific cases it could be useful, but I think it could also suppress warnings that people would still want to be shown. So even if it would be a togglable feature, I'm kind of against that for now but I would like @pi0 opinion about this stuff :) /cc @pi0 PS: That's really a shame that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've discussed further with @atinux on Discord and we decided that's all good :).
Thanks for your great work @Yama-Tomo !
Thank you for your work @Yama-Tomo Could you now open a PR for the docs, the documents to update are: Please comment that |
@atinux I've created PR of docs 👍 nuxt/docs#1374 |
Types of changes
Description
Hi all ✋
This PR is suppress
export ... was not found ...
warnings with typescript.relate: TypeStrong/ts-loader#653
I usually suppress by adding a custom plugin to
nuxt.config.ts
but, I thought it would be useful to support in the Nuxt.This is a suggestion. please close if you don't needs this 🙇
Thank you
Checklist: